Open
Conversation
Member
|
@simonzack The use case for this (according to #56) is for when you use watchify via the command-line. How about if in |
Author
|
@zertosh Well, my implementation keeps the cache. My own use case was for gulp, but you're right that this perhaps is only half the fix, as it doesn't yet address the cmd issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add/remove is done by calling the constructor, which retains the caches so builds remain fast.
I took this approach, since from my reading of the code,
reset()needs to be called somewhere first in the chokidar handler so the pipeline can be modified, sincebundle()was called previously.If there's a better way please let me know and I'll update the PR.